[STORM-2510] update checkstyle configuration to lower violations #2112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyle-7.7 Just ran this command: ``` % curl -o storm-buildtools/storm_checkstyle.xml https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-7.7/src/main/resources/google_checks.xml ```
1. Update from checkstyle-6.11.2 to checkstyle-7.7. 2. Tweak google_checks.xml from checkstyle-7.7 to have the following changes that are more inline with the way the storm code is written: * 4 space indents instead of 2 * line-length limit is 120 instead of 100 3. Exclude the generated thrift code in storm-client from being checked. 4. Update all maxAllowedViolations to be in-sync with the current number of violations, through use of the `update-all-pom-violations.bash` script that is attached to STORM-2510. NOTE: this also fixes STORM-2507.
Contributor
Author
|
@vinodkc & @revans2 & @hmcc & @srishtyagrawal : please 👀 when you have a chance. This is a follow-up to:
|
Contributor
|
Like I said before I am fine with whatever convention we have, so long as we have one. +1 |
Contributor
|
Oops we need a license in |
…), and add the Apache License boilerplate to the storm_checkstyle.xml file
Contributor
Author
|
@revans2 : ah, thanks for pointing out the need for license. I copied how google-cloud-intellij is doing it: I also increased the line limit to 140 and adjusted the maxAllowedViolations accordingly. |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
are more inline with the way the storm code is written:
violations, through use of the
update-all-pom-violations.bashscript thatis attached to STORM-2510.
NOTE: this also fixes STORM-2507.